Getting a Pull Request Merged and Wrapping up

Share this video with your friends

Let’s look at the GitHub commits and list of contributors now that our pull request has been merged. And we’ll wrap this series up with a few tips. Feel free to practice on stack-overflow-copy-paste, and see the Pull Request demonstrated in this lesson here.

Khaled Garbaya

~ 8 years ago

Love the serie, thanks a lot . But I have a small question, when forcing push, won't this break semantic release process and require you to make a manual publish ?

Kent C. Dodds(instructor)

~ 8 years ago

I'm glad you like the series! You're right to be concerned about force pushing. It can be dangerous and it can mess up semantic-release. But this is only true when you force push to the master branch. You can force push to any other branch just fine and because semantic-release doesn't do anything with those branches, it doesn't make a difference.

As a related note, I recommend that you protect your master branch from force pushes: https://help.github.com/articles/about-protected-branches/

Mike

~ 8 years ago

Love this series, because of this series I filed my first issue on GitHub and I plan on creating my own repo. Thanks!

Ioan Lucut

~ 7 years ago

Thanks for the series!

Joey Ng'ethe

~ 7 years ago

This series is great! Kent you continue to impact some invaluable knowledge. I have been using OSS for years now and I took your advice to contribute and give back to the community. I just opened my first PR for code sandbox for I used almost everyday nowadays. This year is the year to start giving back to the community and get my name out there on the map. Cheers!